-
-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exclude error ressources from graphql #5848
Conversation
1051dd0
to
73754aa
Compare
can't we introduce a graphql error operation instead? |
I'd like a little bit more informations about this, also a test covering the issue would be nice not sure if that's the best option |
At the moment the Graphql API is broken - the schema is invalid because I do not know much about this error resource and cannot judge if this is relevant for GraphQL and how to implement this properly. Feel free to work on that solution. But still I would vote to merge this PR before as a quick fix. |
we need a regression test and to fix serialization groups indeed! I'll look into that. |
We investigated and I now understand better what's going on... I'm trying to find a way to test this. |
Thx a lot |
da36e2f
to
73754aa
Compare
49c9340
to
cdb7f5f
Compare
Thanks @jotwea ! |
I noticed that PR #5433 introduced side effects on the GraphQL side which lead to an invalid schema.
{ "errors": [ { "message": "Names must only contain [_a-zA-Z0-9] but \"hydra:title\" does not.", "extensions": {}, "stack": "GraphQLError: Names must only contain [_a-zA-Z0-9] but \"hydra:title\" does not." } ] }
This PR just excludes the Error resources for graphql
see #4994 (comment)