Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove "hydra:" remaining prefix #6624

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

vincentchalamon
Copy link
Contributor

@vincentchalamon vincentchalamon commented Sep 18, 2024

Additionally, api-platform/admin must be updated because of the following error (with hydra_prefix: false):

image

@vincentchalamon vincentchalamon force-pushed the fix/hydra-prefix branch 2 times, most recently from 5080746 to a7ff751 Compare September 18, 2024 14:25
@soyuka soyuka merged commit 4f5f567 into api-platform:3.4 Sep 23, 2024
77 of 78 checks passed
@vincentchalamon vincentchalamon deleted the fix/hydra-prefix branch September 23, 2024 13:56
@burned42
Copy link

burned42 commented Oct 7, 2024

Unfortunately it seems like this introduced a BC break for me with v4.0.3 as even with hydra_prefix: true, the hydra prefix is gone now.

For now I brought back the old behavior by downgrading api-platform/state and api-platform/validator to v4.0.2.

@vincentchalamon
Copy link
Contributor Author

Hi @burned42,

On which schema did you found that the hydra prefix was gone? On a resource schema (with json-ld format), the hydra prefix is still present (cf. API Platform Demo tests). But on an error schema, the hydra prefix has been removed (in 4.0.3). @soyuka can explain further more about this removal.

@burned42
Copy link

burned42 commented Oct 8, 2024

@vincentchalamon yes, that's right. Sorry if I was a bit unspecific here.

I was only talking about the error schema.

@vincentchalamon
Copy link
Contributor Author

@burned42 @soyuka is currently working on a fix: #6704

@burned42
Copy link

burned42 commented Oct 8, 2024

@vincentchalamon @soyuka awesome, thank you :)

@burned42
Copy link

As mentioned in #6701 (comment) it seems like the fix included in version 4.0.4 works 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants