Make Travis fast again #709
Conversation
teohhanhui
force-pushed
the
travis-perf
branch
2 times, most recently
from
b25d6d6
to
a2c5501
Compare
|
Ok the coverage stats seems to be different between xdebug and phpdbg, but I think we're good? ping @api-platform/core-team |
|
|
||
| env: | ||
| global: | ||
| - NPM_CONFIG_PROGRESS='false' |
There was a problem hiding this comment.
Is this still true, thought they fixed it
There was a problem hiding this comment.
It doesn't seem to have an effect in Travis CI environment anyway, since there's no TTY 😛
But there's no harm...
There was a problem hiding this comment.
Sure! Shrinkwrap does speed up things but I'm not sure we've a use case here.
There was a problem hiding this comment.
If it is useless, can you remove it? (simpler is better)
|
Awesome |
| - phpunit --self-update | ||
| - npm install -g swagger-cli | ||
| - if [[ $coverage = 1 ]]; then mkdir -p build/logs build/cov; fi | ||
| - if [[ $coverage = 1 ]]; then wget https://phar.phpunit.de/phpcov.phar; fi | ||
| - if [[ $coverage = 1 ]]; then wget https://github.com/satooshi/php-coveralls/releases/download/v1.0.1/coveralls.phar; fi | ||
|
|
||
| install: | ||
| - if [[ ! $deps ]]; then composer update --no-progress --ansi; fi | ||
| - if [[ $deps = low ]]; then composer update --no-progress --ansi --prefer-lowest --prefer-stable; fi | ||
| - if [[ $coverage = 1 ]]; then composer require --dev --no-update 'phpunit/php-code-coverage:^4.0.1'; fi |
There was a problem hiding this comment.
We should either download the phar or install it using composer, not both :)
There was a problem hiding this comment.
Or maybe I missed something. Why is this lib necessary?
There was a problem hiding this comment.
This is not a new dependency. We're using it in CoverageContext. It was used through a transitive dependency, which is of course something we shouldn't do. (I really hope we have a dependency analysis tool to help us catch such problems!)
Shall we add it to require-dev in composer.json proper?
There was a problem hiding this comment.
It looks good to me to have it in require-dev.
teohhanhui
force-pushed
the
travis-perf
branch
from
5511d32
to
724eca8
Compare
|
@dunglas After adding |
|
It's probably related to minimum versions of PHPUnit's dependencies. Their minimum version should be explicitly added to composer.json, but it's probably enough for now to add this dep in Travis like you've done previously. |
teohhanhui
force-pushed
the
travis-perf
branch
from
724eca8
to
3c3348b
Compare
|
Not a satisfactory solution but that is something to be solved in another PR. 😄 |
|
Thanks @teohhanhui |
Make Travis fast again
But we need to verify that code coverage is working properly.