Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests #787

Merged
merged 1 commit into from
Oct 6, 2016
Merged

Fix tests #787

merged 1 commit into from
Oct 6, 2016

Conversation

teohhanhui
Copy link
Contributor

@teohhanhui teohhanhui commented Oct 6, 2016 •
edited
Loading

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

Related: #777

Tests broken since symfony/symfony@62d28f9

@teohhanhui teohhanhui added the bug label Oct 6, 2016
@soyuka
Copy link
Member

soyuka commented Oct 6, 2016

nice, #774 is still valid?

@teohhanhui
Copy link
Contributor Author

#774 and #777 have become invalid since symfony/symfony@62d28f9

Which is why this PR is necessary.

@teohhanhui teohhanhui merged commit 418211d into api-platform:master Oct 6, 2016
@teohhanhui teohhanhui deleted the fix-tests branch October 6, 2016 09:21
magarzon pushed a commit to magarzon/core that referenced this pull request Feb 12, 2017
@teohhanhui
Merge pull request api-platform#787 from teohhanhui/fix-tests
75f424d 
Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simperfit Simperfit Simperfit approved these changes

@soyuka soyuka soyuka approved these changes

@dunglas dunglas dunglas approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@teohhanhui @soyuka @dunglas @Simperfit