Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api7): add priority support #170

Merged
merged 2 commits into from
Aug 30, 2024
Merged

feat(api7): add priority support #170

merged 2 commits into from
Aug 30, 2024

Conversation

bzp2010
Copy link
Collaborator

@bzp2010 bzp2010 commented Aug 9, 2024

Description

In recent releases, API7 has added support for priority on routes, and this PR adds the priority field.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible

@bzp2010 bzp2010 added the test/api7 Trigger the API7 test on the PR label Aug 9, 2024
@bzp2010 bzp2010 marked this pull request as ready for review August 9, 2024 14:55
@bzp2010
Copy link
Collaborator Author

bzp2010 commented Aug 9, 2024 •
edited
Loading

This feature is not implemented in API7 3.2.13.0, so test failure is expected. The CI will not pass unless we remove the that support.

@bzp2010 bzp2010 marked this pull request as draft August 9, 2024 15:04
@bzp2010 bzp2010 marked this pull request as ready for review August 30, 2024 07:57
@bzp2010 bzp2010 changed the base branch from main to bzp/ci-api7-03021403 August 30, 2024 07:59
@bzp2010 bzp2010 changed the base branch from bzp/ci-api7-03021403 to main August 30, 2024 07:59
@bzp2010 bzp2010 merged commit c428eea into main Aug 30, 2024
6 checks passed
@bzp2010 bzp2010 deleted the bzp/feat-api7-route-priority branch August 30, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pottekkat pottekkat pottekkat approved these changes

@juzhiyuan juzhiyuan juzhiyuan approved these changes

@SkyeYoung SkyeYoung Awaiting requested review from SkyeYoung

@guoqqqi guoqqqi Awaiting requested review from guoqqqi

Assignees
No one assigned
Labels
test/api7 Trigger the API7 test on the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzp2010 @juzhiyuan @pottekkat