Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: uniqueItems validation failed after v0.9 tag . #25

Merged
merged 3 commits into from
Jul 30, 2020
Merged

bugfix: uniqueItems validation failed after v0.9 tag . #25

merged 3 commits into from
Jul 30, 2020

Conversation

membphis
Copy link
Contributor

fix #24.

@membphis
Copy link
Contributor Author

@Gerrard-YNWA please take a look when you have time ^_^

Gerrard-YNWA
Gerrard-YNWA suggested changes Jul 30, 2020
View reviewed changes
lib/jsonschema.lua Outdated Show resolved Hide resolved
@membphis
Copy link
Contributor Author

we can implement it in another way, call lib.deepeq in lib. unique_item_in_array, This way is simpler.

@membphis membphis mentioned this pull request Jul 30, 2020
Closed
@membphis membphis merged commit fd3aef0 into master Jul 30, 2020
@membphis membphis deleted the bugfix-unique-array branch July 30, 2020 01:46
@membphis
Copy link
Contributor Author

@Gerrard-YNWA many thx for your review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gerrard-YNWA Gerrard-YNWA Gerrard-YNWA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: uniqueItems validation failed after v0.9 tag
2 participants
@membphis @Gerrard-YNWA