Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(global_plugins): kong to apisix global rules module #31

Merged
merged 4 commits into from
Oct 20, 2021

Conversation

shuaijinchao
Copy link
Contributor

No description provided.

pkg/kong/globalrules_test.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2021

Codecov Report

Merging #31 (3aad847) into main (487b9ef) will increase coverage by 1.20%.
The diff coverage is 66.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   67.86%   69.06%   +1.20%     
==========================================
  Files          13       13              
  Lines         557      611      +54     
==========================================
+ Hits          378      422      +44     
- Misses        112      122      +10     
  Partials       67       67              
Impacted Files Coverage Δ
pkg/kong/kong.go 24.13% <0.00%> (-1.67%) ⬇️
pkg/kong/globalrules.go 50.00% <50.00%> (-20.59%) ⬇️
pkg/kong/service.go 79.24% <50.00%> (-2.76%) ⬇️
pkg/kong/route.go 64.81% <55.55%> (-2.46%) ⬇️
pkg/kong/plugin.go 75.86% <75.86%> (+25.86%) ⬆️
pkg/kong/consumer.go 84.61% <100.00%> (-2.06%) ⬇️
pkg/utils/utils.go 47.61% <0.00%> (-2.39%) ⬇️
test/e2e/utils/delete.go 45.45% <0.00%> (+3.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 487b9ef...3aad847. Read the comment docs.

@shuaijinchao shuaijinchao merged commit fb37059 into api7:main Oct 20, 2021
shuaijinchao added a commit to shuaijinchao/kong-to-apisix that referenced this pull request Nov 1, 2021
* refactor(global_plugins): kong to apisix global rules module

* test: update unit test

* test: add err check

* test: update rate limiting plugin test config struct
shuaijinchao added a commit that referenced this pull request Nov 1, 2021
* refactor(route): kong to apisix route module

* fix: lint check

* chore: remove routes field for kong service

* feat: compatible with kong deck and kong config

* refactor(global_plugins): kong to apisix global rules module (#31)

* refactor(global_plugins): kong to apisix global rules module

* test: update unit test

* test: add err check

* test: update rate limiting plugin test config struct

* refactor(consumer+plugin): kong to apisix plugin and consumer module (#32)

* refactor(consumer+plugin): kong to apisix plugin and consumer module

* chore: update params and auth common struct

* refactor(upstream): kong to apisix upstream module (#33)

* refactor(upstream): kong to apisix upstream

* chore: target parse support ipv6

* feat: compatible with kong deck and kong config

* feat: refactor global plugin

* chore: add conversion logs

* chore: remove debug backup file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants