Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add consumer e2e test #40

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

shuaijinchao
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #40 (8a7240c) into main (f087efc) will not change coverage.
The diff coverage is n/a.

❗ Current head 8a7240c differs from pull request most recent head 56ddc94. Consider uploading reports for the commit 56ddc94 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main      #40   +/-   ##
=======================================
  Coverage   71.12%   71.12%           
=======================================
  Files          13       13           
  Lines         890      890           
=======================================
  Hits          633      633           
  Misses        173      173           
  Partials       84       84           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f087efc...56ddc94. Read the comment docs.

Copy link
Contributor

@Yiyiyimu Yiyiyimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems something wrong with the codecov, that adding new test files does not affect coverage

@shuaijinchao
Copy link
Contributor Author

Yes, I have not encountered this situation. Do you know how the relationship between test and coverage files is established?

@Yiyiyimu
Copy link
Contributor

Yiyiyimu commented Nov 4, 2021

I think it might relate to

- name: Run test
run: make test
- name: Upload coverage to Codecov
run: bash <(curl -s https://codecov.io/bash)

.PHONY: test
test:
ginkgo -r --progress --trace -coverpkg=./... -coverprofile=coverage.txt

@shuaijinchao
Copy link
Contributor Author

I think it might relate to

- name: Run test
run: make test
- name: Upload coverage to Codecov
run: bash <(curl -s https://codecov.io/bash)

.PHONY: test
test:
ginkgo -r --progress --trace -coverpkg=./... -coverprofile=coverage.txt

Now E2E has included "go test". I will submit a new PR to delete "go test".

@shuaijinchao shuaijinchao merged commit 82f6b7f into api7:main Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants