Upgrade Dredd Transactions and refactor how annotations are processed #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honzajavorek
force-pushed
the
honzajavorek/upgrade-dt
branch
2 times, most recently
from
20b9d7b
to
13c3393
Compare
Please see https://github.com/apiaryio/dredd-transactions/releases and https://github.com/apiaryio/api-elements.js/releases for more details Close #1338
honzajavorek
force-pushed
the
honzajavorek/upgrade-dt
branch
from
13c3393
to
9513b9a
Compare
artem-zakharchenko
approved these changes
May 10, 2019
| const annotationsError = handleRuntimeProblems(apiDescriptions, this.logger); | ||
| if (annotationsError) { callback(annotationsError, this.stats); return; } | ||
| const loggerInfos = toLoggerInfos(apiDescriptions); | ||
| // FIXME: Winston 3.x supports calling .log() directly with the loggerInfo |
There was a problem hiding this comment.
We can reference #1225 here to keep track of the changes.
| if (origin.resourceGroupName) { segments.push(origin.resourceGroupName); } | ||
| if (origin.resourceName) { segments.push(origin.resourceName); } | ||
| if (origin.actionName) { segments.push(origin.actionName); } | ||
| if (origin.exampleName) { segments.push(origin.exampleName); } |
There was a problem hiding this comment.
I understand this is copy-pasted, but you can also do a slightly shorter syntax:
const segments = [
origin.apiName,
origin.resourceGroupName,
origin.resourceName,
origin.actionName,
origin.exampleName,
].filter(Boolean).join(' > ')Apart from shorter declaration it also reduces the function's complexity.
There was a problem hiding this comment.
That's a good suggestion. I'll file it as a DT issue and fix it there. This wile stays copy-pasted and then deleted once DT provides the name directly.
There was a problem hiding this comment.
|
🎉 This PR is included in version 11.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Why this change?
Dredd Transactions contain a lot of new fixes and features (not only) in OAS3 support. There's more and more issues on Dredd which are filed only because Dredd is behind in what has been already developed.
Dredd is behind because new versions of the parsing toolchain caught me off guard during refactoring rather larger portions of the Dredd codebase. This should be the last missing piece, which will address pending issues around annotation line/column numbers and will upgrade Dredd Transactions in the process to address outstanding OAS3 issues.
📝 Related issues and Pull Requests
✅ What didn't I forget?
npm run lint