feat: replace jsonlint with json-parse-helpfulerror #109
Conversation
|
@abacaphiliac Wow! This would be awesome. BTW, credits for #85 belong to @lukateake #84 🙌 I'll review this ASAP. If we get this merged and do the release train up to Dredd, we could finally close #83 and to remove this whole section from Dredd's installation docs 🙏 |
| @validation.body.results.push message | ||
| else | ||
| try | ||
| JSON.parse @body | ||
| jph.parse @body |
There was a problem hiding this comment.
In this case we're not handling the error, so I wonder whether using JSON.parse() wouldn't be faster 🤔
OTOH, it could bring inconsistencies in how Gavel parsers JSON and what it considers to be valid or not - not sure whether there are any discrepancies, but the probability is not low. I guess we're better safe using the same implementation everywhere.
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
jsonlintis unmaintained, and the fork referenced ingavelis not published.my proposal is based on the pull request from @honzajavorek where
jsonlintis replaced withjson-parse-helpfulerrorinstead ofparse-json.json-parse-helpfulerrorappears to work in the browser as well as server.#85