Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-1126-Add-test-assertions #198

Merged
merged 6 commits into from
Feb 6, 2024
Merged

Conversation

Mohammad-Alavi
Copy link
Member

@Mohammad-Alavi Mohammad-Alavi commented Feb 5, 2024

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (refactoring a current feature, method, etc...)
  • Code Coverage (adding/removing/updating/refactoring tests)
  • New feature (non-breaking change which adds functionality)
  • Remove feature (non-breaking change which removes functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@Mohammad-Alavi Mohammad-Alavi added the type: enhancement A proposed improvement or addition to existing features label Feb 5, 2024
@Mohammad-Alavi Mohammad-Alavi self-assigned this Feb 5, 2024
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (6ed5f06) 3.50% compared to head (d18de81) 3.47%.
Report is 2 commits behind head on 8.x.

❗ Current head d18de81 differs from pull request most recent head 0b31b37. Consider uploading reports for the commit 0b31b37 to get more accurate results

Files Patch % Lines
...ts/TestTraits/PhpUnit/TestAssertionHelperTrait.php 0.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               8.x    #198      +/-   ##
==========================================
- Coverage     3.50%   3.47%   -0.03%     
- Complexity     607     613       +6     
==========================================
  Files           85      85              
  Lines         2539    2559      +20     
==========================================
  Hits            89      89              
- Misses        2450    2470      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mohammad-Alavi Mohammad-Alavi marked this pull request as draft February 5, 2024 16:39
@Mohammad-Alavi Mohammad-Alavi marked this pull request as ready for review February 5, 2024 16:39
@Mohammad-Alavi Mohammad-Alavi marked this pull request as draft February 5, 2024 16:40
@Mohammad-Alavi Mohammad-Alavi marked this pull request as ready for review February 6, 2024 14:23
@Mohammad-Alavi Mohammad-Alavi merged commit 36da5a8 into 8.x Feb 6, 2024
3 checks passed
@Mohammad-Alavi Mohammad-Alavi deleted the API-1126-Add-test-assertions branch February 6, 2024 14:24
@Mohammad-Alavi Mohammad-Alavi restored the API-1126-Add-test-assertions branch July 6, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A proposed improvement or addition to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant