-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve metamorph section #1123
Conversation
rework logical flow & structure added admonitions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a few typos, plus left some suggestions 🙂
|
||
## Benefits of metamorph | ||
|
||
Metamorph offers several advantages for developers: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Advantages over what?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, that is true, I do not provide anything to compare Metamorph with so benefits
would make more sense, since there still is a list of positives provided for developers.
sources/platform/actors/development/programming_interface/metamorph.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/programming_interface/metamorph.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/programming_interface/metamorph.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/programming_interface/metamorph.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/programming_interface/metamorph.md
Outdated
Show resolved
Hide resolved
Co-authored-by: František Nesveda <fnesveda@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I just found one typo, otherwise approving
|
||
To make your Actor compatible with the metamorph operation, use `Actor.getInput()` instead of `Actor.getValue('INPUT')`. This method will fetch the input using the right key **INPUT-METAMORPH-1** in case of a metamorphed run. | ||
The metamorph process invovles several key steps. It stops the current Actor's Docker container, then starts a new container using a different Docker image. During this transition, all default storages are preserved. The new input is stored under the _INPUT-METAMORPH-1_ key in the default key-value store, ensuring seamless data transfer between Actor runs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The metamorph process invovles several key steps. It stops the current Actor's Docker container, then starts a new container using a different Docker image. During this transition, all default storages are preserved. The new input is stored under the _INPUT-METAMORPH-1_ key in the default key-value store, ensuring seamless data transfer between Actor runs. | |
The metamorph process involves several key steps. It stops the current Actor's Docker container, then starts a new container using a different Docker image. During this transition, all default storages are preserved. The new input is stored under the _INPUT-METAMORPH-1_ key in the default key-value store, ensuring seamless data transfer between Actor runs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah found it as well and was pushing commit, thank you!
rework logical flow & structure
added admonitions