-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: typo fixes, proxy IP availability #1126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one note about the IP addresses 🙂
sources/platform/proxy/usage.md
Outdated
@@ -32,7 +32,7 @@ If you need to test Apify Proxy before you subscribe, please [contact our suppor | |||
|
|||
| Parameter | Value / explanation | | |||
|---------------------|---------------------| | |||
| Hostname | `proxy.apify.com`, alternatively you can use static IP addresses `18.208.102.16`, `35.171.134.41`. | | |||
| Hostname | `proxy.apify.com`, alternatively you can use static IP addresses `18.208.102.16`, `35.171.134.41`. However, it is **strongly recommended to use the DNS name** (`proxy.apify.com`) as IP addresses are only available based on the current backend targets. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason someone might want to connect directly through the IP addresses? I would be decisive and not list the direct connection option at all, and list only the hostname here, and then list the IP addresses in a separate paragraph outside the table. E.g. "the proxy runs on these two IP addresses, if you need to whitelist them in your firewall".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please, check last commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request is neither linked to an issue or epic nor labeled as adhoc!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request is neither linked to an issue or epic nor labeled as adhoc!
No description provided.