Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: typo fixes, proxy IP availability #1126

Merged
merged 6 commits into from
Jul 30, 2024
Merged

chore: typo fixes, proxy IP availability #1126

merged 6 commits into from
Jul 30, 2024

Conversation

seyhello
Copy link
Contributor

No description provided.

@seyhello seyhello added the t-docs Issues owned by technical writing team. label Jul 30, 2024
@seyhello seyhello requested a review from fnesveda July 30, 2024 07:49
@seyhello seyhello self-assigned this Jul 30, 2024
@seyhello seyhello requested a review from TC-MO as a code owner July 30, 2024 07:49
Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one note about the IP addresses 🙂

@@ -32,7 +32,7 @@ If you need to test Apify Proxy before you subscribe, please [contact our suppor

| Parameter | Value / explanation |
|---------------------|---------------------|
| Hostname | `proxy.apify.com`, alternatively you can use static IP addresses `18.208.102.16`, `35.171.134.41`. |
| Hostname | `proxy.apify.com`, alternatively you can use static IP addresses `18.208.102.16`, `35.171.134.41`. However, it is **strongly recommended to use the DNS name** (`proxy.apify.com`) as IP addresses are only available based on the current backend targets. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason someone might want to connect directly through the IP addresses? I would be decisive and not list the direct connection option at all, and list only the hostname here, and then list the IP addresses in a separate paragraph outside the table. E.g. "the proxy runs on these two IP addresses, if you need to whitelist them in your firewall".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, check last commit

Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👏

Copy link
Contributor

@TC-MO TC-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added this to the 95th sprint - Platform team milestone Jul 30, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

@seyhello seyhello added the adhoc Ad-hoc unplanned task added during the sprint. label Jul 30, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

@seyhello seyhello merged commit d6d5d53 into master Jul 30, 2024
7 checks passed
@seyhello seyhello deleted the fix/typos branch July 30, 2024 12:24
@seyhello seyhello added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-docs Issues owned by technical writing team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants