Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saudi data not actual #43

Closed
FahadAlMutairi5 opened this issue May 4, 2020 · 9 comments
Closed

Saudi data not actual #43

FahadAlMutairi5 opened this issue May 4, 2020 · 9 comments

Comments

@FahadAlMutairi5
Copy link

The source of saudi data change the data value but the apify not updated

@FahadAlMutairi5
Copy link
Author

kindly reminder the bug also today

@Lucie20
Copy link
Contributor

Lucie20 commented May 6, 2020

we are working on the correction, thank you for letting us know

laidihalim added a commit to onidivo/covid-19 that referenced this issue May 7, 2020
laidihalim added a commit to onidivo/covid-19 that referenced this issue May 7, 2020
This was referenced May 7, 2020
@remyoucef remyoucef mentioned this issue May 7, 2020
Merged
@katacek
Copy link
Member

katacek commented May 7, 2020

fix #59 including all cities

@katacek katacek closed this as completed May 7, 2020
@FahadAlMutairi5
Copy link
Author

thanks all , but FYI the deceased key in each city undefined right know

@FahadAlMutairi5
Copy link
Author

EX.
now :
مكة المكرمة: {
infected: "7410",
active: " 5537",
recovered: "1778"
}
but it should like that :
مكة المكرمة: {
infected: "7410",
active: " 5537",
recovered: "1778",
deceased: "95"
}

@FahadAlMutairi5
Copy link
Author

I think you need to change this line in main.js
citiesArray.forEach(x =>
{
data[x]['infected'] = $(strong:contains(${x})).closest('p').find("span[style='color:#e60000']").eq(0).text().replace(',','');
data[x]['active'] = $(strong:contains(${x})).closest('p').find("span[style='color:#e69800']").eq(0).text().replace(',','');
data[x]['recovered'] = $(strong:contains(${x})).closest('p').find("span[style='color:#70a800']").eq(0).text().replace(',','');
})

@katacek
Copy link
Member

katacek commented May 7, 2020

Thanks, you are right. It is because I cannot see the deceased key for each city on the website (https://covid19.moh.gov.sa/en/). Before, we took the data from different endpoint (including deceased key) but those data were not actual.
If I am wrong and the deceased key can be found on the website, it can be fixed easily.

@FahadAlMutairi5
Copy link
Author

yes you are right, but actual the deceased you can find it if you click on the name of city

**95**

Screen Shot 1441-09-14 at 11 05 52 PM

@FahadAlMutairi5
Copy link
Author

after you select the name of city you can find the deceased of this city in الوفيات section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants