fix: fix building projects with TS when puppeteer and playwright are not installed #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B4nan
force-pushed
the
fix-ts-deps
branch
8 times, most recently
from
eb203b3
to
6c7dd67
Compare
B4nan
commented
Jul 21, 2022
| @@ -11,7 +11,9 @@ | |||
| "@crawlee/core": "file:./packages/core", | |||
| "@crawlee/memory-storage": "file:./packages/memory-storage", | |||
| "@crawlee/types": "file:./packages/types", | |||
| "@crawlee/utils": "file:./packages/utils" | |||
| "@crawlee/utils": "file:./packages/utils", | |||
There was a problem hiding this comment.
This is exactly what we want to test, that the build passes without those deps. Adding them makes no sense.
B4nan
commented
Jul 21, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1398