Automatically infer latest spec revision when importing deployments #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theganyo
reviewed
Mar 10, 2023
cmd/registry/patch/deployment.go
Outdated
| @@ -39,11 +39,27 @@ func relativeSpecRevisionName(apiName names.Api, spec string) string { | |||
| } | |||
|
|
|||
| // optionalSpecRevisionName returns a spec revision name if the subpath is not empty | |||
| func optionalSpecRevisionName(deploymentName names.Deployment, subpath string) string { | |||
| func optionalSpecRevisionName(ctx context.Context, client *gapic.RegistryClient, deploymentName names.Deployment, subpath string) (string, error) { | |||
There was a problem hiding this comment.
As this is quite a vague function name, we should make sure the comment fully documents what to expect.
There was a problem hiding this comment.
yes, it should probably be renamed. I'll suggest something in the next commit.
There was a problem hiding this comment.
resolveSpecRevisionName with a better comment.
theganyo
approved these changes
Mar 10, 2023
Codecov Report
@@ Coverage Diff @@
## main #1079 +/- ##
==========================================
- Coverage 68.01% 67.99% -0.02%
==========================================
Files 147 147
Lines 11975 11990 +15
==========================================
+ Hits 8145 8153 +8
- Misses 3131 3136 +5
- Partials 699 701 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1078
tests are coming in this PR