Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIWARE integration task#1 #3552

Closed
ilarimikkonen opened this issue Aug 24, 2018 · 14 comments
Closed

FIWARE integration task#1 #3552

ilarimikkonen opened this issue Aug 24, 2018 · 14 comments
Assignees
Labels

Comments

@ilarimikkonen
Copy link
Member

APInf needs to expose two settings from API umbrella:

  • global request settings: IDP App ID
  • sub url settings: Required headers

see screencaps

@ilarimikkonen
Copy link
Member Author

task1.PNG
task2.PNG
task3.PNG

@ilarimikkonen
Copy link
Member Author

screencaps are for illustration; changes via management API

@ilarimikkonen
Copy link
Member Author

  • we need a task for APInf UI

@preriasusi
Copy link
Contributor

#3552

@preriasusi
Copy link
Contributor

Regex to be .* when writing Required Headers.

@preriasusi
Copy link
Contributor

UI_3551.png

@preriasusi
Copy link
Contributor

UI design there. Should it be grouped still under a "OAuth IDP settings" etc.?

@fdelavega
Copy link

The required headers stuff under the sub-url parameters is used to specify tenants of the different datasets which are registered using the sub-url settings.

In this regard, if the required headers functionality is going to be supported, then the method and URL regex for sub-urls need to be also supported

@matleppa
Copy link
Member

@fdelavega
About parameter Required Headers (RH).

  • Is the goal that the parameter RH can be given separately for each HTTP method in sub-URL request settings?
    So for each method is needed following fields for parameters
  • HTTP method (is also "any" needed as a method
  • regex
  • Required Headers

@vinaytech Changes needed to current implementation according to answers.

@ilarimikkonen
Copy link
Member Author

ilarimikkonen commented Sep 3, 2018

confirmed with Ficodes: we need to support all methods including "any". Supporting multiple rules for same method is optional. regex needs to be given separately to all methods once / method. Each setting group has three parameters, method (pulldown), regex (text field) and required headers (text field)

@ilarimikkonen
Copy link
Member Author

ilarimikkonen commented Sep 3, 2018

ficodeintegrationUi.png

please use this style of ui implementation, this is visible for example in nightly if you select "custom rate limits" in proxy settings

ficodeintegrationUi2.PNG

@ilarimikkonen
Copy link
Member Author

ilarimikkonen commented Sep 3, 2018

setting can be placed after rate limits in the proxy setting UI. For initial implementation it can be visible all the time

@ilarimikkonen
Copy link
Member Author

there is one "IDP App ID" per API

@Nazarah
Copy link
Contributor

Nazarah commented Sep 4, 2018

@vinaytech please add me as a reviewer when u create a PR for this issue. I'd like to check the UI.

@ghost ghost removed the in progress label Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants