Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating apinf:fiware package to version 0.2.1 fixing internal error … #3663

Merged
merged 1 commit into from
Dec 20, 2018
Merged

updating apinf:fiware package to version 0.2.1 fixing internal error … #3663

merged 1 commit into from
Dec 20, 2018

Conversation

ilarimikkonen
Copy link
Member

…problem

Closes #

Changes

Describe your changes here as a bulleted list:

  • change one
  • change two

Developer checklist

This checklist is to be completed by the PR developer:

  • Alternative solutions were compared/discussed before writing code
    • trade-offs with this solution are considered acceptable
  • Code in this PR adheres to the project styleguide
  • This pull request does not decrease project test coverage
  • If the code changes existing database collection(s), migration has been written
  • If UI texts are added or changed, all texts are internationalized

Reviewer checklist

Reviewed by: @username1

This list is to be completed by the pull request reviewer:

  • Code works as described/expected
  • Code seems to be error free
    • no browser console errors visible
    • no server console errors visible
    • passes CI build
  • Code is written in a way that promotes maintainability
    • easy to understand
    • well organized
    • follows project coding standards and conventions
    • well documented

@ghost ghost assigned ilarimikkonen Dec 20, 2018
@ghost ghost added the in progress label Dec 20, 2018
matleppa
matleppa approved these changes Dec 20, 2018
View reviewed changes
Copy link
Member

@matleppa matleppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@matleppa matleppa merged commit d8ccefd into develop Dec 20, 2018
@ghost ghost removed the in progress label Dec 20, 2018
@matleppa matleppa deleted the bugfix/update-fiware-login-pacakge-to-0.2.1 branch December 20, 2018 11:22
@ilarimikkonen ilarimikkonen mentioned this pull request Dec 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matleppa matleppa matleppa approved these changes

Assignees

@ilarimikkonen ilarimikkonen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilarimikkonen @matleppa