Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify middleware #5

Merged
merged 2 commits into from Oct 3, 2018

Conversation

2 participants
@mabar
Copy link
Member

commented Oct 3, 2018

  • implement IMiddleware (save because contributte/middlewares is required)
  • remove instanceof check (it is done by php itself)
  • remove try catch (it was doing absolutely nothing)

@mabar mabar requested a review from f3l1x Oct 3, 2018

@f3l1x f3l1x merged commit 142008d into master Oct 3, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on simplify-middleware at 100.0%
Details

@f3l1x f3l1x deleted the simplify-middleware branch Oct 3, 2018

@f3l1x f3l1x added this to the v0.4 milestone Oct 3, 2018

@f3l1x

This comment has been minimized.

Copy link
Member

commented Oct 3, 2018

Cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.