Ingest edgelists #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
movestill
reviewed
Oct 11, 2020
| with concurrent.futures.ThreadPoolExecutor( | ||
| _N_PARALLEL_REQUESTS | ||
| ) as executor: | ||
| result_futures = list( |
There was a problem hiding this comment.
Is there some built in error handling with the ThreadPoolExecutor should the dynamo writes fail?
There was a problem hiding this comment.
That there is not! I think I need to handle this at the iterator over result_futures, though really i feel like I'm still doing this so wrong... is there really no way to batch inserts faster than one-by-one?!
There was a problem hiding this comment.
No, I think you do have to do one-by-one unless they added a new API call since I last worked with Dynamo (which may have been last year).
There was a problem hiding this comment.
😭 Adding an issue for this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.