Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check and remove duplicate strings related to connection errors #1244

Closed
ihalaij1 opened this issue Sep 1, 2023 · 0 comments · Fixed by #1246
Closed

Check and remove duplicate strings related to connection errors #1244

ihalaij1 opened this issue Sep 1, 2023 · 0 comments · Fixed by #1246
Assignees
Labels
area: linguistic form Textual issues about wording and language experience: moderate required knowledge estimate requester: team The issue is raised by a person inside the A+ developer team type: feature New feature or change to a feature

Comments

@ihalaij1
Copy link
Contributor

ihalaij1 commented Sep 1, 2023

The below was mentioned in PR #1185:

There are multiple, a little different error messages for the grading connection errors in the code base. Some of them could be maybe removed and replaced with the almost identical ones. It is not immediately obvious why there are multiple similar strings (in django.po). Some of them are used in similar situations (based on a quick glance), some in a clearly different scenario. Since most of them are old, we should check if they are really up-to-date. Some of them promise that the course staff is emailed about the errors, but I am not sure if the email is really sent in all cases.

Similar strings include:

  • SUBMISSION_ERROR_ALERT_COMMUNICATION_ERROR_W_SERVICE
  • EXERCISE_ERROR_COMMUNICATION
  • EXERCISE_SERVICE_ERROR_CONNECTION_FAILED
  • ASSESSMENT_SERVICE_ERROR_CONNECTION_FAILED
  • ERROR_ALERT_EXERCISE_ASSESSMENT_SERVICE_MALFUNCTIONING
@ihalaij1 ihalaij1 self-assigned this Sep 1, 2023
@ihalaij1 ihalaij1 moved this to Under review in A+ sprints Sep 1, 2023
ihalaij1 added a commit to ihalaij1/a-plus that referenced this issue Sep 1, 2023
ihalaij1 added a commit to ihalaij1/a-plus that referenced this issue Sep 1, 2023
@markkuriekkinen markkuriekkinen added area: linguistic form Textual issues about wording and language type: feature New feature or change to a feature experience: moderate required knowledge estimate requester: team The issue is raised by a person inside the A+ developer team labels Sep 19, 2023
@markkuriekkinen markkuriekkinen added this to the v1.20 - Summer 2023 milestone Sep 19, 2023
@github-project-automation github-project-automation bot moved this from Under review to Done in A+ sprints Sep 19, 2023
murhum1 pushed a commit to murhum1/a-plus that referenced this issue Dec 21, 2023
ihalaij1 added a commit to ihalaij1/a-plus that referenced this issue Dec 22, 2023
ihalaij1 added a commit to ihalaij1/a-plus that referenced this issue Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: linguistic form Textual issues about wording and language experience: moderate required knowledge estimate requester: team The issue is raised by a person inside the A+ developer team type: feature New feature or change to a feature
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants