Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interactive code to have frame and grading #1169

Merged
merged 1 commit into from
May 29, 2023

Conversation

yusein-ali
Copy link
Contributor

Description

To support interactive code blocks to have exercise title frame.
What?
chapter.js is modified to support new element classes
[ANSWER HERE]

Why?
We need to have interactive code blocks that can be executed in A+ servers.
[ANSWER HERE]

How?

[ANSWER HERE]

Fixes #

Testing

Remember to add or update unit tests for new features and changes.

What type of test did you run?

  • Accessibility test using the WAVE extension.
  • Django unit tests.
  • Selenium tests.
  • Other test. (Add a description below)
  • [X ] Manual testing.

[ADD A DESCRIPTION ABOUT WHAT YOU TESTED MANUALLY]

Did you test the changes in

  • [ X] Chrome
  • [ X] Firefox
  • This pull request cannot be tested in the browser.

Think of what is affected by these changes and could become broken

Translation

Programming style

  • [X ] Did you follow our style guides?
  • Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

  • documents inside the doc directory.
  • README.md.
  • Aplus Manual.
  • Other documentation (mention below which documentation).

Is it Done?

  • Reviewer has finished the code review
  • After the review, the developer has made changes accordingly
  • Customer/Teacher has accepted the implementation of the feature

Clean up your git commit history before submitting the pull request!

@markkuriekkinen markkuriekkinen self-requested a review May 29, 2023 09:32
@markkuriekkinen markkuriekkinen self-assigned this May 29, 2023
@markkuriekkinen markkuriekkinen added area: javascript This issue concerns the JavaScript code effort: hours Estimated to take less than one day, from the creation of a new branch to the merging labels May 29, 2023
@markkuriekkinen markkuriekkinen added this to the v1.18 milestone May 29, 2023
Interactive code blocks may have an exercise frame in
the user interface and they may be graded.
Copy link
Contributor

@markkuriekkinen markkuriekkinen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix some minor whitespace issues here and merge the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: javascript This issue concerns the JavaScript code effort: hours Estimated to take less than one day, from the creation of a new branch to the merging
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants