Fix 404 error in inspect submitter view #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lainets
force-pushed
the
error_submissions
branch
2 times, most recently
from
34b4ffe
to
963e42d
Compare
This will add error submissions to some APIs, to the submission list dropdowns in the course instance page, and to NextUnassessedSubmitterView (this means the view falls back on error submissions if no proper submissions exist, which seems to be in accordance with rest of the view code). Closes apluslms#1193.
lainets
force-pushed
the
error_submissions
branch
from
963e42d
to
19db570
Compare
markkuriekkinen
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What?
Include error submissions in CachedPoints, and prioritize INITIALIZED and WAITING over ERROR and REJECTED submissions when falling back to last submission in inspect views.
Why?
#1193
Fixes #1193
Testing
What type of test did you run?
Tested that the best submission is prioritized, and INITIALIZED and WAITING are prioritized over ERROR and REJECTED when a best submission doesn't exist.
Did you test the changes in
Is it Done?