Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_submission_allowed messages all have the same severity #1343

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

khattam2
Copy link
Contributor

@khattam2 khattam2 commented Mar 4, 2024

Fixes #1226

Description

What?

check_submission_allowed messages all have the same severity

Why?

submission_check is given a flag whether it should print the strings as errors or warnings but this does not make sense

How?

The flag has been removed and severity is decided by the statement.

Testing

image

Remember to add or update unit tests for new features and changes.

What type of test did you run?

  • Accessibility test using the WAVE extension.
  • Django unit tests.
  • Selenium tests.
  • Other test. (Add a description below)
  • Manual testing.

[ADD A DESCRIPTION ABOUT WHAT YOU TESTED MANUALLY]

Did you test the changes in

  • Chrome
  • Firefox
  • This pull request cannot be tested in the browser.

Think of what is affected by these changes and could become broken

Translation

Programming style

  • Did you follow our style guides?
  • Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

  • documents inside the doc directory.
  • README.md.
  • Aplus Manual.
  • Other documentation (mention below which documentation).

Is it Done?

  • Reviewer has finished the code review
  • After the review, the developer has made changes accordingly
  • Customer/Teacher has accepted the implementation of the feature

Clean up your git commit history before submitting the pull request!

@ihalaij1 ihalaij1 self-requested a review March 12, 2024 11:07
@ihalaij1 ihalaij1 self-assigned this Mar 12, 2024
@ihalaij1
Copy link
Contributor

This PR requires some more changes to correctly classify and display error/warning/info messages from functions one_has_submissions() and one_has_access().

I will be making these changes myself.

@ihalaij1 ihalaij1 force-pushed the message_severity branch 3 times, most recently from 0c822d7 to c01ba67 Compare April 11, 2024 12:52
@ihalaij1 ihalaij1 requested review from murhum1 and removed request for ihalaij1 April 11, 2024 12:52
@ihalaij1 ihalaij1 assigned murhum1 and unassigned ihalaij1 Apr 11, 2024
@ihalaij1 ihalaij1 force-pushed the message_severity branch 7 times, most recently from 363eac6 to a2a3fb8 Compare April 11, 2024 14:20
Fixes apluslms#1226

Co-authored-by: Jimmy Ihalainen <jimmy.ihalainen@gmail.com>
@murhum1 murhum1 merged commit b18689d into apluslms:master Apr 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

check_submission_allowed messages all have the same severity
3 participants