Remove promise nesting in buildImage() when no callback #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 19, 2022
kb2ma
force-pushed
the
build_image_stuck
branch
from
e509ce9
to
db00bd0
Compare
This was referenced Oct 16, 2022
Closed
|
@apocas , any feedback at all on this PR? I see a thumbs-up from the author of the original change. |
|
👍 |
dfunckt
added a commit
to balena-io/balena-cli
that referenced
this pull request
Jun 30, 2023
v3.3.4 introduces a regression that is fixed by apocas/dockerode#695 but Dockerode has not published a version that includes the fix yet. Pin the dependency to ensure we don’t ever update to a broken version. Change-type: patch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a single Promise as in v3.3.3, but maintains the asynchronous approach to
.dockerignoreprocessing added in v3.3.4.Also added unit tests for the no-callback, Promise based path.
Fixes #696