Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Replaces asyncclick with click #131

Merged
merged 1 commit into from
May 22, 2021

Conversation

apoclyps
Copy link
Owner

@apoclyps apoclyps commented May 22, 2021

What's Changed

Following the removal of #95 and #109, reviews no longer need to use async. This also resolves a bug where exiting reviews was difficult due to a blocking call.

asciicast

resolves #130

closes #129

Technical Description

This PR removes asyncclick and upgrades to click==8.0.1: https://pypi.org/project/click/

@apoclyps apoclyps merged commit ec0cec0 into main May 22, 2021
@apoclyps apoclyps deleted the kyleharrison/bug-130/remove-async branch May 22, 2021 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Async isn't actually being used, and prevents ctrl+c from correctly exiting the app
1 participant