Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent command/session #139

Closed
bertini97 opened this issue May 16, 2024 · 5 comments · Fixed by #142
Closed

Inconsistent command/session #139

bertini97 opened this issue May 16, 2024 · 5 comments · Fixed by #142
Assignees
Labels
bug Something isn't working
Milestone

Comments

@bertini97
Copy link

bertini97 commented May 16, 2024

Tuigreet displays, under the CMD: label, either the session it's about to start or the command to launch. If you manually select a session, for example "Sway", you will get CMD: Sway, and then you will login into sway. However, if you ask tuigreet to remember it, at the next login you will be presented with CMD: sway, which is the command.

Here session and command are almost the same, but take for example the case of SwayFX, where the session is called "SwayFX" but shares the same command sway.

I think if tuigreet last started a session, and not a command, it should display the session name. But I also think a better solution would be to provide the name of the session and the command separately, as to avoid all confusion. Something like

ESC  F2: Change command  F3: Change session  SESSION: Sway  COMMAND: sway
ESC  F2: Change command  F3: Change session  SESSION: None  COMMAND: /bin/bash

Or even

ESC  SESSION: Sway (F3: change)  COMMAND: sway (F2: change)

Thanks for the attention.

@apognu apognu added the enhancement New feature or request label May 17, 2024
@apognu
Copy link
Owner

apognu commented May 17, 2024

You haven't filled out the template, please provide the required information. For example, which version of tuigreet are you using are what is your command-line for running it?

We changed the way sessions are remembered a while back and, save for a bug (which is possible), the actual Name of the remembered session should now be displayed, not its command.

Thank you.

@bertini97
Copy link
Author

Yes, sorry. I'm running tuigreet 0.9.0, and the command is

tuigreet --remember --remember-session --asterisks

So far the only indication that tuigreet is showing the command and not the session is because it's not capitalized. I'll test some more and report back.

@apognu
Copy link
Owner

apognu commented May 19, 2024

I think I might see where the issue might be. It should only occur with --remember-session, not --remember-user-session and in this case, it would prefer the command name instead of the session.

I'll confirm when I get a computer back and if it is the case, it is indeed not the intended behavior.

@apognu apognu self-assigned this May 19, 2024
@apognu apognu added this to the 0.9.1 milestone May 19, 2024
@apognu apognu added bug Something isn't working and removed enhancement New feature or request labels May 19, 2024
@apognu apognu mentioned this issue May 19, 2024
@apognu
Copy link
Owner

apognu commented May 19, 2024

I think I found the issue, it will be included in the 0.9.1 hotfix. Thanks for reporting.

@apognu
Copy link
Owner

apognu commented Jun 2, 2024

This is now available in the 0.9.1 version of tuigreet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants