Replace deprecated OneLogin::RubySaml::Settings#issuer with sp_entity_id #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamstegman
reviewed
Feb 22, 2022
There was a problem hiding this comment.
Thanks for making this change! I think after #213, we are no longer testing against 1.11 or even 1.12. So the test helper method is probably unnecessary, we should just be able to use the latest.
tkalliom
force-pushed
the
use-sp_entity_id
branch
2 times, most recently
from
7264eea
to
77e3033
Compare
tkalliom
force-pushed
the
use-sp_entity_id
branch
from
77e3033
to
6398660
Compare
The method sp_entity_id was introduced, and issuer deprecated, in ruby-saml version 1.11. References are contained only in docs and test code.
tkalliom
force-pushed
the
use-sp_entity_id
branch
from
6398660
to
65cf35c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method sp_entity_id was introduced, and issuer deprecated, in ruby-saml version 1.11. References are contained only in docs and test code.
Note that
DefaultIdpEntityIdReaderusesOneLogin::RubySaml::SloLogoutrequest#issuer, a distinct and still valid method.