Update File.exists? reference #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should remove the `gems/ruby-3.1.2/gems/devise_saml_authenticatable-1.9.0/lib/devise_saml_authenticatable/saml_config.rb:17: warning: File.exists? is deprecated; use File.exist? instead` warnings that are output in tests and server logs
adamstegman
approved these changes
May 31, 2022
|
Looks like a test needs to be updated: |
|
Thanks @adamstegman - I really struggled with getting the tests to run (at-all) locally so this was a bit of a punt! 😄 |
Ensure new File.exist call is tested
adamstegman
reviewed
Jun 27, 2022
Ensure File.exist? call is tested instead of File.exists?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should remove the
devise_saml_authenticatable/saml_config.rb:17: warning: File.exists? is deprecated; use File.exist? insteadwarnings that are output in tests and server logs