Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grouped region frame resets object state inappropriately #64

Closed
Major- opened this issue Aug 3, 2015 · 5 comments
Closed

Grouped region frame resets object state inappropriately #64

Major- opened this issue Aug 3, 2015 · 5 comments

Comments

@Major-
Copy link
Member

Major- commented Aug 3, 2015

The grouped region update frame will sometimes reset an object to its default state when the player walks a reasonable distance away.

The object should not be reset.
@rmcmk
Copy link
Contributor

rmcmk commented Aug 25, 2015

Working on this -- will create a pull request when ready.

@WizardJesse1
Copy link
Contributor

@ryleykimmel nice for keeping apollo fixed up :)

Major- added a commit that referenced this issue Aug 28, 2015
@Major-
Fix issue #64.
6f5a910
@Major-
Copy link
Member Author

Major- commented Aug 28, 2015

@ryleykimmel Seems like I've fixed it in the commit referenced above.

@Major- Major- closed this as completed Aug 28, 2015
@rmcmk
Copy link
Contributor

rmcmk commented Aug 28, 2015

Looks good, what is meant by the TODO in Region#removeEntity?

@Major-
Copy link
Member Author

Major- commented Aug 28, 2015

Whoops @ryleykimmel , meant to remove that comment... will correct shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Major- @WizardJesse1 @rmcmk