-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APOLLO-2103] Fix SSRF #2105
[APOLLO-2103] Fix SSRF #2105
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2105 +/- ##
============================================
- Coverage 50.05% 49.95% -0.11%
Complexity 1981 1981
============================================
Files 401 401
Lines 12384 12403 +19
Branches 1268 1276 +8
============================================
- Hits 6199 6196 -3
- Misses 5742 5763 +21
- Partials 443 444 +1
Continue to review full report at Codecov.
|
apollo-portal/src/main/resources/static/scripts/controller/SystemInfoController.js
Outdated
Show resolved
Hide resolved
...-portal/src/main/java/com/ctrip/framework/apollo/portal/controller/SystemInfoController.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/health 未授权访问漏洞 解决了吗?如果已解决,哪个版本中解决了?@[nobodyiam] |
What do you mean by |
I tried to resolve the unauthorized access vulnerability (/health) by turning off the health endpoint of the AdminService module, which caused no configuration information to be seen on the Apollo-Portal interface |
If the adminService module configuration "management. Endpoints. Web. Exposure. Exclude = health", the upper right corner of the portal page complains, don't see any configuration information .....The picture above is my test results |
Right...I forgot the portal will ping admin-service's health endpoint to check whether it's healthy. apollo/apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/api/AdminServiceAPI.java Lines 42 to 44 in d15331b
|
Fix SSRF, resolve apolloconfig#2103
fix SSRF, resolve #2103