Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APOLLO-2103] Fix SSRF #2105

Merged
merged 9 commits into from
Apr 7, 2019
Merged

[APOLLO-2103] Fix SSRF #2105

merged 9 commits into from
Apr 7, 2019

Conversation

kezhenxu94
Copy link
Member

fix SSRF, resolve #2103

@codecov-io
Copy link

codecov-io commented Apr 2, 2019

Codecov Report

Merging #2105 into master will decrease coverage by 0.1%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2105      +/-   ##
============================================
- Coverage     50.05%   49.95%   -0.11%     
  Complexity     1981     1981              
============================================
  Files           401      401              
  Lines         12384    12403      +19     
  Branches       1268     1276       +8     
============================================
- Hits           6199     6196       -3     
- Misses         5742     5763      +21     
- Partials        443      444       +1
Impacted Files Coverage Δ Complexity Δ
...apollo/portal/controller/SystemInfoController.java 13.46% <0%> (-7.76%) 3 <0> (ø)
...mework/apollo/portal/component/PortalSettings.java 65.07% <0%> (-4.77%) 5% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f50dc4e...97ffde8. Read the comment docs.

@coveralls
Copy link

coveralls commented Apr 2, 2019

Coverage Status

Coverage decreased (-0.1%) to 53.535% when pulling 97ffde8 on kezhenxu94:master into f50dc4e on ctripcorp:master.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit ad448d7 into apolloconfig:master Apr 7, 2019
@liutao5121
Copy link

/health 未授权访问漏洞 解决了吗?如果已解决,哪个版本中解决了?@[nobodyiam]

@nobodyiam
Copy link
Member

@liutao5121

What do you mean by /health 未授权访问漏洞 解决了吗??
I believe /health doesn't expose any sensitive information, and it could be used by external platforms like Kubernetes readiness probe.
But if you really want to close this endpoint, you may simply configure it via the standard spring boot way.
Currently, apollo exposes info,health,metrics,prometheus by default

@liutao5121
Copy link

liutao5121 commented Mar 30, 2022

I tried to resolve the unauthorized access vulnerability (/health) by turning off the health endpoint of the AdminService module, which caused no configuration information to be seen on the Apollo-Portal interface

@liutao5121
Copy link

image

@liutao5121
Copy link

liutao5121 commented Mar 30, 2022

If the adminService module configuration "management. Endpoints. Web. Exposure. Exclude = health", the upper right corner of the portal page complains, don't see any configuration information .....The picture above is my test results

@nobodyiam
Copy link
Member

Right...I forgot the portal will ping admin-service's health endpoint to check whether it's healthy.

public Health health(Env env) {
return restTemplate.get(env, "/health", Health.class);
}

CrackerCat pushed a commit to CrackerCat/apollo-1 that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

接口"/system-info/health"存在SSRF漏洞
5 participants