wip: Upgrade astroport messaging to v5 #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ApolloGie
force-pushed
the
dev/astroport-native-lp-tokens
branch
9 times, most recently
from
0cda1e3
to
71b8221
Compare
ApolloGie
force-pushed
the
dev/astroport-native-lp-tokens
branch
4 times, most recently
from
cc37ee2
to
847bc3e
Compare
ApolloGie
force-pushed
the
dev/astroport-native-lp-tokens
branch
11 times, most recently
from
c6534b5
to
6fb8b1c
Compare
ApolloGie
force-pushed
the
dev/astroport-native-lp-tokens
branch
from
bc35aa0
to
aa46a97
Compare
ApolloGie
force-pushed
the
dev/astroport-native-lp-tokens
branch
from
5826364
to
5bcc131
Compare
ApolloGie
force-pushed
the
dev/astroport-native-lp-tokens
branch
3 times, most recently
from
5224cf7
to
389c6a2
Compare
ApolloGie
force-pushed
the
dev/astroport-native-lp-tokens
branch
from
389c6a2
to
46ef9f2
Compare
apollo-sturdy
force-pushed
the
dev/astroport-native-lp-tokens
branch
from
85cc2c3
to
5e7a816
Compare
apollo-sturdy
force-pushed
the
dev/astroport-native-lp-tokens
branch
from
7215d26
to
3f02a62
Compare
apollo-sturdy
commented
Aug 26, 2024
Comment on lines
+292
to
+297
| fn execute_tx( | ||
| &self, | ||
| _tx_bytes: &[u8], | ||
| ) -> test_tube::RunnerResult<cosmrs::proto::tendermint::v0_37::abci::ResponseDeliverTx> { | ||
| todo!() | ||
| } |
There was a problem hiding this comment.
Can we fix this or nah?
src/multi_test/runner.rs
Outdated
| let alice = app.init_account(&[coin(1000, "uosmo")]).unwrap(); | ||
|
|
||
| let res = instantiate_astro_token(&app, &alice).unwrap(); | ||
|
|
||
| println!("MsgInstantiateContractRes: {:?}", res); |
There was a problem hiding this comment.
remove println
src/astroport/utils.rs
Outdated
Comment on lines
334
to
336
| astro_token: AssetInfoV2::Token { | ||
| contract_addr: Addr::unchecked(&astro_token), | ||
| }, |
There was a problem hiding this comment.
Change to native astro token?
apollo-sturdy
force-pushed
the
dev/astroport-native-lp-tokens
branch
from
b72e435
to
77119b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.