Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accepting custom fetch in ApolloBoost #3590

Merged

Conversation

mbaranovski
Copy link
Contributor

@mbaranovski mbaranovski commented Jun 15, 2018

Accepting custom fetch to be passed when creating ApolloClient instance. It solves #3578

Checklist:

  • Make sure all of the significant new logic is covered by tests

…so that ApolloBoost can be used on node.js environment.
@apollo-cla
Copy link

@mbaranovski: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@mbaranovski
Copy link
Contributor Author

mbaranovski commented Jun 15, 2018

Build on CircleCI timed out. Needs to be retriggered I believe.

@hwillson hwillson self-assigned this Jul 9, 2018
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @mbaranovski - thanks very much! We're all set here - merging shortly.

@hwillson hwillson merged commit 7076e36 into apollographql:master Jul 9, 2018
@mbaranovski
Copy link
Contributor Author

Thanks, @hwillson. I've just noticed that my test is a false positive. No assertions are being triggered. It is a simple change. I've made a commit. Do you want me to open a separate PR for that or you will add it in some other PR? mbaranovski@eeb142e

@hwillson
Copy link
Member

No problem @mbaranovski - if you could open that in a separate PR, that would be great. Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants