-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accepting custom fetch in ApolloBoost #3590
Accepting custom fetch in ApolloBoost #3590
Conversation
…so that ApolloBoost can be used on node.js environment.
@mbaranovski: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
Build on CircleCI timed out. Needs to be retriggered I believe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @mbaranovski - thanks very much! We're all set here - merging shortly.
Thanks, @hwillson. I've just noticed that my test is a false positive. No assertions are being triggered. It is a simple change. I've made a commit. Do you want me to open a separate PR for that or you will add it in some other PR? mbaranovski@eeb142e |
No problem @mbaranovski - if you could open that in a separate PR, that would be great. Thanks! |
Accepting custom fetch to be passed when creating ApolloClient instance. It solves #3578
Checklist: