Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call clearStore callbacks after clearing store #4695

Merged
merged 3 commits into from
Apr 16, 2019

Conversation

ds8k
Copy link
Contributor

@ds8k ds8k commented Apr 11, 2019

This makes clearStore work similarly to how resetStore works, which is to say the cache is first cleared and then callbacks are run. This resolves issue #4694

@apollo-cla
Copy link

@ds8k: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ds8k! I made some simplifications that are possible now that we do not lazily create client.queryManager, but the functional change you proposed seems like a good idea.

@benjamn benjamn merged commit dc8f5a4 into apollographql:master Apr 16, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants