Apollo Client bundling examples and reporting #5449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamn
requested changes
Oct 15, 2019
examples/bundling/no-tree-shaking/rollup-ac3-no-react/package.json
Outdated
Show resolved
Hide resolved
benjamn
force-pushed
the
bundling-reference
branch
from
97fe2f1
to
a48dfa9
Compare
benjamn
requested changes
Oct 15, 2019
| input: './src/index.js', | ||
| output: { | ||
| file: `./public/js/${outputPrefix}.min.js`, | ||
| format: 'cjs', |
There was a problem hiding this comment.
Hmm, when I try to run the apps, I'm seeing
Uncaught ReferenceError: require is not defined
in the browser console for the Rollup apps, I think because the output format is CJS, which doesn't run natively in browsers. Am I missing something here?
There was a problem hiding this comment.
Ah yes - graphql-tag causes some interesting bundling issues for sure. I'll fix this - thanks!
There was a problem hiding this comment.
@benjamn Digging into this, I'm not seeing the same thing; can you run a npm run build on AC first, then try running the app again? Since the example app is referencing the compiled files in dist, maybe they just need to be updated first.
This commit introduces a few different Apollo Client bundling example applications. These applications demonstrate how Apollo Client can be bundled using modern bundling tools like Rollup and webpack, along with features like tree shaking / dead code elimination. Each application can be run on its own, but the larger intent of these changes is to provide a way to gather metrics around production bundle sizes for applications using Apollo Client, with its dependencies. So instead of reporting on the bundle size for just `@apollo/client`, the provided `bundlesize.sh` script can be used to gather full Apollo Client based application bundle size metrics. These metrics should help give us a better understanding of Apollo related bundle sizes during real world production use.
benjamn
force-pushed
the
bundling-reference
branch
from
550d9a5
to
236d9d8
Compare
benjamn
approved these changes
Oct 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a few different Apollo Client bundling example applications. These applications demonstrate how Apollo Client can be bundled using modern bundling tools like Rollup and webpack, along with features like tree shaking / dead code elimination. Each application can be run on its own, but the larger intent of these changes is to provide a way to gather metrics around production bundle sizes for applications using Apollo Client, with its dependencies. So instead of reporting on the bundle size for just
@apollo/client, the providedbundlesize.shscript can be used to gather full Apollo Client based application bundle size metrics. These metrics should help give us a better understanding of Apollo related bundle sizes during real world production use.