Migrate React Apollo HOC/Components into Apollo Client #6558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwillson
commented
Jul 8, 2020
|
@benjamn @jcreighton I know it looks like there is a lot to review here, but I think it's safe to skip over the incoming tests. I updated most of the tests to work with the AC codebase a bit better (e.g. by using |
benjamn
approved these changes
Jul 8, 2020
hwillson
force-pushed
the
migrate-hoc-components
branch
2 times, most recently
from
969d15c
to
3d045dd
Compare
Move the `MockedProvider` tests from the `react-apollo` repo, updating them to use hooks instead of Apollo HOC/Components.
Since we're shutting down the React Apollo repo, let's move the Query, Mutation and Subscription components into this repo. At some point in the future we're going to officially remove these components, but since they already wrap our hooks internally, there is very little additional overhead needed to maintain them for now. These components will not be accessible from the main `@apollo/client` entry point. They will be given their own entry point in a future commit, making them accessible via `@apollo/client/react/components` (which means modern bundlers will be able to properly tree-shake them, when they aren't being used).
This test was originally in the components `Query.test.tsx` file, but for some reason it isn't working properly after the component code was migrated into this repo. Instead of spending more time troubleshooting it for the component code, it's more important to verify it works with `useQuery` (which it does).
Migrating the React Apollo `Mutation` component code into this repo uncovered a bug with the way we're setting options in `useMutation`. This commit makes sure we're no longer accidentally overwriting `defaultOptions` settings with `undefined`.
The `fetchMore` test was triggering a React `act` error due to the `result.fetchMore` call happening during render.
This commit makes RA's `graphql` (and related) HOC functionality part of the Apollo Client project. All tests have been updated to work with the AC codebase.
Having to make `hoist-non-react-statics` a dependency just for the `graphql` HOC is unfortunate. This might change.
This commit creates `@apollo/client/react/components` and `@apollo/client/react/hoc` package entry points.
We're running into an interesting Circle Workflows issue, where old cached data is not being properly removed. As a troubleshooting start, we'll bump the cache key version to make sure we're using a new cache. As a bonus using v3 here lines up with AC v3.
Node 12 is the current LTS version.
We have a lot of delays intertwined in our old React Apollo tests that aren't necessary (and actually lead to random test failures). The delays in this test in particular cause CI to randomly fail. Since we don't need these delays, let's get rid of them.
The previous iteration of this test failed randomly in CI.
Delays in the HOC SSR tests are causing random CI failures, so let's get rid of all of them (they aren't needed to properly verify functionality).
Adjustments to fix the use of `react-scripts` in the webpack based app, as well as package lock updates.
hwillson
force-pushed
the
migrate-hoc-components
branch
from
3d045dd
to
046cff5
Compare
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the React Apollo HOC/components functionality from https://github.com/apollographql/react-apollo into the Apollo Client codebase, making it available through the following new entry points:
While we recommend using React hooks with Apollo Client (and our hooks are available from the main
@apollo/clientbundle directly), providing access to the HOC/Component based alternatives requires very little additional maintenance overhead. This is due to the fact that the HOC/Components call Apollo hooks behind the scenes (they're really just hook wrappers). Making this functionality available from Apollo Client directly also means that we can fully deprecate/archive the React Apollo project.One more additional benefit to moving the HOC/Components into Apollo Client, is that we get to leverage their extensive test suite to help verify Apollo hooks functionality. The HOC/Component tests are validating a large number of edge cases that we are not validating through our hooks test suite directly.
It's important to note that HOC/Component functionality is not available from the main
@apollo/clientbundle directly, making this functionality fully tree-shakable by modern bundlers.