fix: Introspection-based schema download creates duplicate @defer directive
#440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
✅ Deploy Preview for apollo-ios-docc canceled.
|
calvincestari
commented
Jul 25, 2024
| new Source(documentString, "Test Query", { line: 1, column: 1 }) | ||
| ); | ||
|
|
||
| it("ensure the introspection JSON is correct for test", () => { |
There was a problem hiding this comment.
Introspection JSON is difficult to parse and read so I've added tests like this one to ensure that the JSON doesn't get changed in a way that would invalidate what the test is meant to be checking for.
BobaFetters
pushed a commit
that referenced
this pull request
Jul 30, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios-codegen
that referenced
this pull request
Jul 30, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Jul 30, 2024
83488f68 fix: Introspection-based schema download creates duplicate `@defer` directive (#440) git-subtree-dir: apollo-ios-codegen git-subtree-split: 83488f68370f0c7ec5bb3239218c737a1b7a9650
BobaFetters
pushed a commit
that referenced
this pull request
Jul 30, 2024
… download creates duplicate `@defer` directive git-subtree-dir: apollo-ios-codegen git-subtree-mainline: b14cab1 git-subtree-split: 83488f68370f0c7ec5bb3239218c737a1b7a9650
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apollographql/apollo-ios#3417
This changeset splits the logic for adding the defer directive to the document between SDL and introspection sources. SDL sources can be inspected as a
DocumentNodewith all declared directives available but introspection sources, once converted to aDocumentNode, do not contain all declared directives and instead need to be inspected as the schema built from the introspection source; I do not know whether this is a bug in graphql-js or intended behaviour but I will take that up with them separately.ApolloSchemaDownloaderInternalTeststo ensure that even though the JS logic has been fixed there isn't some fetch-schema-workflow specific difference to creating the duplicate directive.