fix: @dynamicMember conflicting field name
#2965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-ios-docs canceled.
|
AnthonyMDev
approved these changes
Apr 17, 2023
| @@ -68,6 +69,19 @@ struct MockObjectTemplate: TemplateRenderer { | |||
| """ | |||
| } | |||
|
|
|||
| private func conflictingFieldNameProperties(_ fields: [TemplateField]) -> TemplateString { | |||
| """ | |||
| \(fields.map { """ | |||
There was a problem hiding this comment.
Nit: might be more performant to compute an intersection with the TestMockConflictingFieldNames set and then just map over those? I could be wrong, but I believe that set intersection computation is very fast b/c of hashing algorithms. This is so so minor though, I'm not really worried about making the change.
There was a problem hiding this comment.
Nothing about fields nor the FieldCollector is a Set unfortunately, I don't think we're going to get much benefit out of going that route here.
calvincestari
force-pushed
the
fix/hash-clash
branch
from
0929a0a
to
0c6ca47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2950
@dynamicMembersubscript.Mocksubscript setters to use a common private_setfunction that can be called from initializers too.