chore(compiler): use Display impls for OperationType, DirectiveLocation #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goto-bus-stop
commented
Jan 20, 2023
|
|
||
| #[source_code] | ||
| pub src: Arc<str>, | ||
|
|
||
| #[label("{} is not a valid location", self.dir_loc)] | ||
| #[label("{} is not a valid location for this directive", self.dir_loc)] |
There was a problem hiding this comment.
didn't catch this in review earlier but I think this message could be improved a bit … maybe something like "cannot use directive @xyz here"
There was a problem hiding this comment.
I guess the thing is that the label is more visually prominent than the "main" error message, and our "main" message contains the important information.
goto-bus-stop
commented
Jan 20, 2023
crates/apollo-compiler/test_data/diagnostics/0050_directives_in_invalid_locations.txt
Show resolved
Hide resolved
lrlna
reviewed
Jan 20, 2023
Comment on lines
-320
to
-331
| impl From<OperationType> for String { | ||
| fn from(op_type: OperationType) -> Self { | ||
| if op_type.is_subscription() { | ||
| "Subscription".to_string() | ||
| } else if op_type.is_mutation() { | ||
| "Mutation".to_string() | ||
| } else { | ||
| "Query".to_string() | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
i think removing this is technically a breaking change eh?
There was a problem hiding this comment.
Yes you can no longer do op_type.into(), you have to do op_type.to_string() instead. So very minor but breaking nonetheless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed a small improvement opportunity while merging
maininto #414…OperationTypealready has aDisplayimpl, so we don't actually need a separateInto<String>: users can doty.to_string()and it will useDisplay.DirectiveLocationalso has aInto<String>impl. If we use aDisplayimpl instead, we can printDirectiveLocations directly in format strings. Then we can also just stick theDirectiveLocationvalue into our diagnostics, instead of stringifying them first, which makes the diagnostic more programmatically useful.