Bug fix - implement missing parser validation for interface and object having missing fields #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinnou
requested review from
lrlna,
goto-bus-stop and
SimonSapin
as code owners
tinnou
force-pushed
the
parser-validation-missing-fields
branch
from
a4246c6
to
a4bf64e
Compare
goto-bus-stop
approved these changes
Apr 2, 2024
Merged
This was referenced Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The parser is a bit lenient around letting types being defined without fields.
The example below should fail parsing but doesn't today:
This PR implements the missing validation to bail parsing for object types and interfaces when defined as empty (within curly braces).
The parser already implemented this validation for enum and input types.