Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracerLogger.submit is not a function #30

Closed
wclr opened this issue Jun 15, 2016 · 19 comments
Closed

tracerLogger.submit is not a function #30

wclr opened this issue Jun 15, 2016 · 19 comments
Assignees

Comments

@wclr
Copy link

wclr commented Jun 15, 2016

Trying apollo server.
Just got an error:

Unhandled rejection TypeError: tracerLogger.submit is not a function
@helfer
Copy link
Contributor

helfer commented Jun 15, 2016

This should have been fixed by an earlier PR. We didn't publish a new version for that though. Will do so now. After an update this error should be gone.

@wclr
Copy link
Author

wclr commented Jun 15, 2016

I have also got the error after make this correcton

 rejection TypeError: Cannot read property 'submit' of undefined

@helfer helfer reopened this Jun 15, 2016
@helfer
Copy link
Contributor

helfer commented Jun 15, 2016

You're saying you get this error with 0.1.5? @jbaxleyiii can you confirm?

@whitecolor: Do you have a stack trace? And can you share how you are calling apolloServer?

@wclr
Copy link
Author

wclr commented Jun 15, 2016

Yes update version 0.1.5
I get the error probably you can add illegal item to schema:

  schema {
    query: Query
    mutation: Mutation
    notation: Notation
  }

At least I get this error no this and trying access /graphql endpoint

@helfer
Copy link
Contributor

helfer commented Jun 15, 2016

I'm assuming you get this error in the console on the server, but it still works and you get a response on the client, right?

@wclr
Copy link
Author

wclr commented Jun 15, 2016

no, client sends error

@helfer
Copy link
Contributor

helfer commented Jun 15, 2016

@whitecolor: Do you have a full stack trace on the server and/or the client?

@wclr
Copy link
Author

wclr commented Jun 16, 2016

Unhandled rejection TypeError: Cannot read property 'submit' of undefined
    at ...\node_modules\apollo-server\dist\apolloServer.js:289:19
    at processImmediate [as _immediateCallback] (timers.js:383:17)
From previous event:
    at ...\node_modules\apollo-server\dist\apolloServer.js:287:8
    at Layer.handle [as handle_request] (...\node_modules\express\lib\router\layer.js:95:5)
    at trim_prefix (...\node_modules\express\lib\router\index.js:312:13)
    at ...\node_modules\express\lib\router\index.js:280:7
    at Function.process_params (...\node_modules\express\lib\router\index.js:330:12)
    at next (...\node_modules\express\lib\router\index.js:271:10)
    at Function.handle (...\node_modules\express\lib\router\index.js:176:3)
    at router (...\node_modules\express\lib\router\index.js:46:12)
    at Layer.handle [as handle_request] (...\node_modules\express\lib\router\layer.js:95:5)
    at trim_prefix (...\node_modules\express\lib\router\index.js:312:13)
    at ...\node_modules\express\lib\router\index.js:280:7
    at Function.process_params (...\node_modules\express\lib\router\index.js:330:12)
    at next (...\node_modules\express\lib\router\index.js:271:10)
    at ...\server\index.js:63:7
    at Layer.handle [as handle_request] (...\node_modules\express\lib\router\layer.js:95:5)
    at trim_prefix (...\node_modules\express\lib\router\index.js:312:13)
    at ...\node_modules\express\lib\router\index.js:280:7
    at Function.process_params (...\node_modules\express\lib\router\index.js:330:12)
    at next (...\node_modules\express\lib\router\index.js:271:10)
    at expressInit (...\node_modules\express\lib\middleware\init.js:33:5)
    at Layer.handle [as handle_request] (...\node_modules\express\lib\router\layer.js:95:5)
    at trim_prefix (...\node_modules\express\lib\router\index.js:312:13)
    at ...\node_modules\express\lib\router\index.js:280:7
    at Function.process_params (...\node_modules\express\lib\router\index.js:330:12)
    at next (...\node_modules\express\lib\router\index.js:271:1

@helfer
Copy link
Contributor

helfer commented Jun 16, 2016

That is indeed the line I thought it was. I'm not sure why this works in our tests, but not in your code. Could you provide a minimal reproduction so I can run it and debug it myself? Doesn't even have to be minimal. Any reproduction I can reasonably set up and run in a few minutes will do.

@wclr
Copy link
Author

wclr commented Jun 16, 2016

Have you tried do such thing:

 schema {
    query: Query
    mutationWrongName: Mutation
  }

and register apolloServer with such schema, then access graphiQL?

@helfer
Copy link
Contributor

helfer commented Jun 16, 2016

I'm 99% sure that that's not the cause of the error you're observing, so I don't think it's worth trying. The easiest way for me to find out what's going on is if you could make a repo on GitHub and instructions for how to reproduce the error with the code in that repo.

@wclr
Copy link
Author

wclr commented Jun 16, 2016

The easiest way for me is not make such mistake and don't get this error ;)
Ok, if I will be able I will try to provide reproduction.

@helfer
Copy link
Contributor

helfer commented Jun 29, 2016

@whitecolor any update on the reproduction? I would love to see one, so we can debug this.

@wclr
Copy link
Author

wclr commented Jun 29, 2016

No, I think may be closed. If I will encounter and reproduce can be reopened then.

@helfer
Copy link
Contributor

helfer commented Jun 30, 2016

Okay, thanks!

@helfer helfer closed this as completed Jun 30, 2016
@linonetwo
Copy link

Any progress on this? I get into the same problem in OSX using graphql-tools 0.4.2 but with nothing wrong in Windows.

@linonetwo
Copy link

@whitecolor are you using OSX?

@helfer
Copy link
Contributor

helfer commented Sep 26, 2016

@linonetwo which version of apollo-server are you using? Any code referring to tracer was removed in 0.2, afaik.

@linonetwo
Copy link

@helfer Sorry for that, I was on client side graphQL server for too long, not knowing server side server has upgraded to apollo-server. After upgrading to apollo-server, everything is fine 👍

abernix added a commit that referenced this issue Jul 30, 2019
This reverts commits 0de2942, 97b3f68 and 293e28d.

While the change in #3089 change was seemingly justified and straightforward
(and as #3106 points out, perhaps _too_ straightforward!  😄), it seems
that there was more to the change from `accept` to `@hapi/accept` and `boom`
to `@hapi/boom` than just a name change.  It seems that the packages may
have dropped support for Node.js 6.

While Node.js 6 is no longer supported by the Node Foundation, for
semantic versioning reasons we weren't intending to completely drop support
for it until Apollo Server 3.x.

Maybe there's a more granular update here that maintains this support, but
this update wasn't as simple as it would have seemed to be at face value
(i.e. not a straight package rename of an otherwise internal dependency).

Happy to consider re-landing a similar thing, but we need to make it more
clear in the `CHANGELOG.md` and possibly reserve it for Apollo Server 3.x,
but for now, should revert this to make sure we're not shipping a broken
integration for Hapi users, as reported in #3106.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants