Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subscription callback support - update to latest version #7743

Closed
dariuszkuc opened this issue Sep 29, 2023 · 1 comment · Fixed by #7793
Closed

subscription callback support - update to latest version #7743

dariuszkuc opened this issue Sep 29, 2023 · 1 comment · Fixed by #7793
Assignees

Comments

@dariuszkuc
Copy link
Member

While we are trying to move towards GA on the callback protocol (still in preview) we made few changes to the protocol.

Current changes*:

  • router should specify maximum supported callback protocol version in all their messages
  • subgraphs should specify their callback protocol version (in headers) in all their messages
  • drop heartbeat message in favor of simpler check message (i.e. send heartbeats per each subscription)
    • heartbeat message required grouping subscription IDs per calling router without providing an easy way to group it (i.e. subgraphs would have to parse callback URLs to group heartbeats) which is error prone.**

See: apollographql/router#3884

*additional changes may be necessary as we finalize the protocol
**we may revisit this optimization in the future callback protocol versions

Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
For general questions, we recommend using StackOverflow or our discord server.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants