Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not remove Query/Mutation/Subscription types when schema is included if schema references those types #3260

Merged

Conversation

JoeTravisKiva
Copy link
Contributor

Attempting to resolve #3100
Where including a schema descriptor that references the default type names for Query, Mutation or Subscription prevents the intended extensions from appearing in the federated schema

Where including a schema descriptor that references the default type names for Query, Mutation or Subscription
prevents the intended extensions from appearing in the federated schema
@apollo-cla
Copy link

@JoeTravisKiva: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@DevYukine
Copy link

if this fixes #3100 i would really appreciate it because i can't get my JVM GraphQL Endpoint to work with Apollo-Gateway 😞

@telbot
Copy link

telbot commented Sep 18, 2019

@trevor-scheer would you have an idea when this pull request could be reviewed, possibly merged if it fixes the original issue?

@trevor-scheer
Copy link
Member

This looks great, thank you for the contribution @JoeTravisKiva! I'll merge now and get this released first thing Monday morning 👍

@trevor-scheer trevor-scheer merged commit 6440c2c into apollographql:master Sep 20, 2019
trevor-scheer added a commit that referenced this pull request Sep 20, 2019
@markguinn
Copy link

Any chance this will still see a release today?

@telbot
Copy link

telbot commented Sep 24, 2019

@trevor-scheer I'd also very much appreciate a release today if at all possible. Appreciate the support on this one.

@trevor-scheer
Copy link
Member

@markguinn @telbot apologies for the delay on this, this is released in @apollo/federation@0.10.0 😄

Release commit:
6100fb5

abernix pushed a commit to apollographql/federation that referenced this pull request Sep 4, 2020
…ed if schema references those types (apollographql/apollo-server#3260)

Resolve apollographql/apollo-server#3100 where including a schema descriptor that references the default type names for
Query, Mutation or Subscription prevents the intended extensions from appearing in the
federated schema.


Apollo-Orig-Commit-AS: apollographql/apollo-server@6440c2c
abernix pushed a commit to apollographql/federation that referenced this pull request Sep 4, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Including the schema definition in the { _service { sdl } } results in GraphQLSchemaValidationError
6 participants