Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI-317 Add clients and number of operations checked to markdown output #1164

Merged
merged 6 commits into from
Apr 5, 2019

Conversation

justinanastos
Copy link
Contributor

This also:

  • Adds tests for the singular version of nouns in the markdown. Some were not being pluralized correctly, now we're checking it.
  • Replace ' with backticks in some places

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)

    This piggybacks on other related PRs; this doesn't need to change the changelog

  • Make sure all of the significant new logic is covered by tests

  • Rebase your changes on master so that they can be merged easily

  • Make sure all tests and linter rules pass

Copy link
Contributor

@evans evans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think we should have a changelog entry, since the PR updates the behavior of the cli and we've already released your previous work ✨

@justinanastos justinanastos force-pushed the justin/UI-317/update-checks-comment branch from c4a1534 to 2dca419 Compare April 4, 2019 15:38
@justinanastos justinanastos merged commit 853494f into master Apr 5, 2019
@justinanastos justinanastos deleted the justin/UI-317/update-checks-comment branch April 5, 2019 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants