Allow legacy targets to be used when manually specified #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -81,7 +81,7 @@ export default class Generate extends Command { | |||
|
|
|||
| let inferredTarget: TargetType = "" as TargetType; | |||
| if (flags.target) { | |||
| if (["swift", "typescript", "flow", "scala"].includes(flags.target)) { | |||
| if (["swift", "typescript", "ts", "flow", "scala", "typescript-legacy", "ts-legacy", "flow-legacy"].includes(flags.target)) { | |||
There was a problem hiding this comment.
Maybe we should get rid of the ts aliases? It seems confusing to have multiple names for the same target.
There was a problem hiding this comment.
I was mostly thinking about compatibility with apollo-codegen here. Is it okay to drop target names now?
There was a problem hiding this comment.
As this is a new CLI, I think we should favor clarity over backwards compatibility. Plus, I think in apollo-codegen we didn't have typescript-legacy but typescript-modern so it's breaking anyway?
There was a problem hiding this comment.
Good point, I'll drop ts.
shadaj
force-pushed
the
allow-legacy-targets
branch
from
bc5e95e
to
a64f9ed
Compare
shadaj
force-pushed
the
allow-legacy-targets
branch
from
a64f9ed
to
95607f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.