Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Associate *.gql files with graphql language in GraphQLProject #740

Merged
merged 1 commit into from
Nov 27, 2018

Conversation

brabeji
Copy link
Contributor

@brabeji brabeji commented Nov 26, 2018

Codegen wasn't working for me with my files ending in ".gql". As my IDE plugin recognizes "*.gql" files as graphql, this is very confusing.

I see two possible further improvements:

  1. Warn when including a file without language association
  2. Fallback to graphql language

Codegen wasn't working for me with my files ending in ".gql". As my IDE plugin recognizes "*.gql" files as graphql, this is very confusing. 

I see two possible further improvements:
1. Warn when including a file without language association
2. Fallback to `graphql` language
@jbaxleyiii
Copy link
Contributor

@brabeji ah great! Thanks for adding this!

@jbaxleyiii jbaxleyiii merged commit 8c66c0c into apollographql:master Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants