Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for fastify #402

Closed
phra opened this issue May 24, 2017 · 5 comments
Closed

add support for fastify #402

phra opened this issue May 24, 2017 · 5 comments

Comments

@phra
Copy link
Contributor

phra commented May 24, 2017

hi,

it would be nice to have also official support for fastify.

are you considering it?
@helfer
Copy link
Contributor

helfer commented Jun 9, 2017

Hi @phra I'd be happy to merge a PR that adds support for fastify 😉

phra added a commit to phra/graphql-server that referenced this issue Jun 11, 2017
@phra
feat(integrations): add fastify support, fixes apollographql#402
71eb626
@phra
Copy link
Contributor Author

phra commented Jun 11, 2017

here it is: #421

@phra phra mentioned this issue Jun 11, 2017
Closed
@helfer
Copy link
Contributor

helfer commented Jun 23, 2017

Hey, really sorry for the about-face, but after discussing with the team we think that the extra maintenance burden is not justifiable at this moment. I'd like to make it up to you though, so if you DM me on Twitter or on the Apollo Slack I'll make sure we send you some Apollo swag! ❤️

@helfer helfer closed this as completed Jun 23, 2017
@ghost
Copy link

ghost commented Jul 20, 2017

Hi! I love Apollo and am falling in love with fastify and was sad to see this wouldn't be supported in the near future. I tried out an implementation as a plugin, so if anyone has an interest in using these things together, by all means do. Hope you guy's are happy with it!

@phra
Copy link
Contributor Author

phra commented Jul 20, 2017

@coopnd big up! 🎉 i didn't have time in these weeks to work on the plugin.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phra @helfer