This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
fix: require react-apollo based on module env #3029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any thoughts on when this could land? |
|
So... I could keep updating this with the latest master, but perhaps there's different plans, and this is going to be handled in a different way? I imagine it's not rare for people to have mocked providers in styleguides/storybooks these days? Anyway, please let me know if this is not relevant or according to your roadmap, so I can stop worrying/checking this MR and implement a local alternative solution. |
hwillson
approved these changes
May 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #2900 again. #2907 fixed MockedProvider for cases where
cjsis used, but not in situations that use ESM, e.g. webpack. This PR requires./instead, which causes Node.js to load themain(react-apollo.cjs.js), andwebpackto load themodule(react-apollo.esm.js) field inpackage.json.This works for both my use cases: tests with Jest & styleguide with webpack, but I might be missing something obvious.