This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
Add script to create gzipped file in development & report gzip size on weigh in #640
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, react-apollo uses
gzip-size
to get the gzip size without writing a.gz
file to disk.travis-weigh-in
requires an actual file to work with, making it incompatible withgzip-size
.To solve this, this PR replaces
gzip-size
with a simple script that saves the compressed gzip and uses that file for file size calculation for bothnpm run filesize
andtravis-weigh-in
scripts.The compression strategy utilized by
/scripts/gzip.js
is identical to what's used ingzip-size
, with both usingzlib
set to level 9. The main change is thatgzip.js
creates a.gz
file.Also, the added
.gz
file in/dist
might be helpful for people wanting to use gzipped versions ofreact-apollo
in development.Summary of changes:
gzip.js
script to/scripts
to create compressed gzips (used bycompress:browser
)compress:browser
script topackage.json
to handle creation of compressedindex.js.gz
for consumption by thefilesize
andtravis-weigh-in
scriptsnpm run compress:browser
to the end ofcompile:browser
gzip-size
as a devDependencyThis PR addresses #574