Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use stdin as sdl input #108

Merged
merged 10 commits into from
Dec 4, 2020
Merged

use stdin as sdl input #108

merged 10 commits into from
Dec 4, 2020

Conversation

JakeDawkins
Copy link
Contributor

@JakeDawkins JakeDawkins commented Dec 2, 2020 •
edited
Loading

Resolves #87

Screenshot showing the same schema pushed from stdin and a file work the same (and the result is "no changes")

image

@JakeDawkins JakeDawkins added feature 🎉 new commands, flags, functionality, and improved error messages status - needs review and removed status - working in progress labels Dec 2, 2020
EverlastingBugstopper
EverlastingBugstopper suggested changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few things here and there but this is looking good!

src/command/graph/push.rs Show resolved Hide resolved
src/command/graph/push.rs Show resolved Hide resolved
src/command/subgraph/push.rs Outdated Show resolved Hide resolved
src/command/subgraph/push.rs Outdated Show resolved Hide resolved
src/command/subgraph/push.rs Show resolved Hide resolved
@JakeDawkins JakeDawkins mentioned this pull request Dec 4, 2020
Closed
EverlastingBugstopper
EverlastingBugstopper approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

src/command/graph/push.rs Outdated Show resolved Hide resolved
src/utils/parsers.rs Outdated Show resolved Hide resolved
@JakeDawkins JakeDawkins merged commit e90a8be into main Dec 4, 2020
@JakeDawkins JakeDawkins deleted the jake/stdin branch December 4, 2020 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EverlastingBugstopper EverlastingBugstopper EverlastingBugstopper approved these changes

@ashleygwilliams ashleygwilliams Awaiting requested review from ashleygwilliams

Assignees
No one assigned
Labels
feature 🎉 new commands, flags, functionality, and improved error messages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support stdin for commands
2 participants
@JakeDawkins @EverlastingBugstopper